-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update s_region following tweakreg #1455
Comments
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think tweakreg currently updates only the image WCS but not the s_region. The s_region is used to determine the boundaries of the CCDs, e.g., in the MAST viewer, and we should update it when we update the WCS.
I think the WCS gets replaced here:
https://github.com/spacetelescope/romancal/blob/main/romancal/tweakreg/tweakreg_step.py#L273
but I think that's it.
Vaguely relatedly, we don't update other WCS keywords like ra/dec_ref, roll_ref. I don't think there is a good way for us to update those in the current scheme, though, and still be able to reproduce the WCS, so I don't think we should tackle that at present.
The text was updated successfully, but these errors were encountered: