Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update casjobs notebooks with login credetials once the CI can handle them #207

Open
eteq opened this issue Sep 2, 2022 · 0 comments
Open

Comments

@eteq
Copy link
Collaborator

eteq commented Sep 2, 2022

In #203 some notebooks were added that use MAST casjobs, which requires a specific login (more details in #203 (comment)). The notebook should require no change to get this to work, the only thing needed is the addition of CASJOBS_USERID and CASJOBS_PW envrionment variables. These, are, however "secrets" in the sense that the PW certainly should not be publicly visible. The solution is to use one of the "secrets" mechanisms backed into CI (Circle, Travis, and Github Actions all support this).

However, given the impending switch to a GA-based CI system, we decided it was better to just wait setting that up until the new CI was working. So this issue is a reminder to create those secrets (which is done via github UI but I think requires admin powers) once the GA CI is up and running.

(cc @therealzoidberg @trenton3983 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant