Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module for puppet 6 support #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mwhahaha
Copy link

We don't need to wrap the definition in a parser function as it should
just be loaded.

Fixes: #39

@EmilienM
Copy link
Contributor

👍 Thanks for fixing it.

@mwhahaha mwhahaha changed the title Correct tdagent provider definition Fix module for puppet 6 support Jun 26, 2019
There are three issues for puppet 6 tests.

The first is that the tdagent provider definition is incorrect. We
don't need to wrap the definition in a parser function as it should
just be loaded.

The second is that we need to include the fluentd when testing the
plugin resource so that the relationship matcher works correctly.

The third is that yumrepo has been moved to it's own module and must be
defined as a dependency.

There is also an issue with the acceptance test because we don't have
the required dependencies to build the test plugin.

Fixes: soylent#39
@mwhahaha
Copy link
Author

looks like td-agent is broken itself, not sure the best way to address it. will look into it if I have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tdagent package provider fails under puppet 6.5.0
2 participants