Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Document.symbols that have no definition inside that document #60

Open
olafurpg opened this issue Jun 29, 2022 · 1 comment · May be fixed by #72
Open

Ignore Document.symbols that have no definition inside that document #60

olafurpg opened this issue Jun 29, 2022 · 1 comment · May be fixed by #72
Assignees
@tjdevries
Labels
graph/scip team/graph

Comments

@olafurpg
Copy link
Member

Currently, the emitted LSIF has weird behavior if you add Document.symbols that have no definition occurrences in that document. We should ignore these symbols, and optionally print a warning to notify that these symbols are ignored. The warning message could be formatted like "did you intend to put this symbol into Index.external_symbols?
@olafurpg
Copy link
Member Author

We should also update the spec to indicate that Document.symbols with no definition are ignored.

@olafurpg olafurpg linked a pull request Aug 24, 2022 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjdevries tjdevries

Labels
graph/scip team/graph
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: skip exported symbols with no definition sourcegraph/scip
3 participants
@olafurpg @tjdevries @varungandhi-src