Smibhid UI log not logging correct IP from request

[sam57719]

Believe it's being proxied by docker.

Might be able to add --proxy-headers to the unicorn run command on the webserver to pass through the real ip.

[sam57719]

Looking like we might need a reverse proxy in front of the webserver container to add the x-real-ip or x-forwarded-for headers with the real IP.

Unless we change to docker host networking

@sjefferson99 thoughts?

[sjefferson99]

What do we need the IP for?

[sam57719]

Currently logging the docker network gateway to the smibhid-ui-log db - tis incorrect, and is annoying. Would be a good thing to fix. A proxy using caddy seems really easy.

Steps:

1. add caddy to the docker-compose files.
2. remove webserver_port override ability from smib-webserver and hardcode internal port to '80' (would be handled by caddy.
3. create a Caddyfile with 3 lines

http:// {
    reverse_proxy smib-webserver:80
}

I will try it as I think this will be beneficial down the line to have the correct IP address logged. Also means we can resolve an IP to the hostname if the client doesn't provide the device-hostname header.

[sjefferson99]

Given the smibhid code does send a hostname and we have no specific plans to add a device that can't, the Ip address seems superfluous. But by all means have a go at working out how to solve with a reverse proxy providing it doesn't add complexity that will make smib less reliable or less secure.

[sam57719]

If anything - it makes it easier to secure the webserver behind https if and when it goes publicly accessible

[sam57719]

Smib (prod) looks to be logging correct ips! Need to establish why

[sam57719]

Working fine on prod smib-pi, not on own pi

SMIB-PI: docker 26.1.3 - working
Own Pi: docker 27.1.1 - not working - even with reverse proxy