Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document api endpoints #215

Open
sam57719 opened this issue Aug 11, 2024 · 4 comments
Open

Document api endpoints #215

sam57719 opened this issue Aug 11, 2024 · 4 comments
Assignees
Labels
Discussion 📄 documentation Improvements or additions to documentation
Milestone

Comments

@sam57719
Copy link
Collaborator

Basic:

Create readme that must be updated every time a new endpoint is created.

Simple:

Alternatively, we could add all existing endpoints and new endpoints to the fastapi webserver, meaning they would show up in the swagger docs. However, this goes against the nice plugin architecture we have.

Experimental:

I will also investigate dynamically creating the swagger docs based on the plugin definitions. This would require each plugin to define a request and response model (which could get passed through into fastapi). Would require the http decorator issue.

@sam57719 sam57719 added Discussion ⚙ framework framework related 💡 idea Possible ideas for the future 📄 documentation Improvements or additions to documentation 🔌 plugin plugin related 🔮 enhancement New feature or request 🧪experimental experimental changes labels Aug 11, 2024
@sam57719 sam57719 self-assigned this Aug 11, 2024
@sam57719
Copy link
Collaborator Author

Experimental
https://stackoverflow.com/a/73292280

@sjefferson99
Copy link
Member

I would like autogenerated swagger, so option 3 sounds like a good one to explore. Might need option 1 for now, just in case we never get 3 and end up with a mammoth docs task.

@sam57719
Copy link
Collaborator Author

Option 1 will be done, and will create a branch for my experimental option 3 (I think it's possible)

@sjefferson99 sjefferson99 added this to the SMIB v1.3 milestone Aug 11, 2024
@sam57719
Copy link
Collaborator Author

This issue will be used for the basic version - manual documentation

@sam57719 sam57719 removed 🔮 enhancement New feature or request 💡 idea Possible ideas for the future 🔌 plugin plugin related ⚙ framework framework related 🧪experimental experimental changes labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion 📄 documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants