Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support json.dumps args and kwargs in SelfDescribingJson.to_string #263

Open
edgarrmondragon opened this issue Jun 14, 2022 · 0 comments
Open

Comments

@edgarrmondragon
Copy link
Contributor

Is your feature request related to a problem? Please describe.

This is just a nice to have. Useful for debugging the contents of an event or context.

Describe the solution you'd like

Allow passing the arguments for json.dumps in SelfDescribingJson.to_string.

def to_string(self) -> str:
return json.dumps(self.to_json())

Describe alternatives you've considered

I considered subclassing SelfDescribingJson, but this might be something others find useful.

Additional context

I can start working on a PR if this is something the maintainers are interested in having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant