Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vep download cache vs vep annotate #365

Open
lczech opened this issue May 24, 2021 · 3 comments
Open

vep download cache vs vep annotate #365

lczech opened this issue May 24, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@lczech
Copy link

lczech commented May 24, 2021

Snakemake version
snakemake-wrappers: 0.74.0

Describe the bug
The vep download cache wrapper uses the vep_install --AUTO cf mode, which downloads the cache and fasta data. However, the vep annotate wrapper expects that the cache directory has exactly one subdirectory, and hence fails when the cache was downloaded with the wrapper.

Proposed solution
Use --AUTO c instead.

In feature request issue 366, I have furthermore posted a suggestion for a feature where I also added a more flexible solution for this bug. The relevant part:

# Get a param from the config that defaults to c, that is, download the cache only,
# but can be changed by the user to also download fasta by providing `automode: cf` in the config.
# This would trigger the single-subdirectory check in the vep annotate wrapper though.
automode = snakemake.params.get("automode", "c")

shell(
    "vep_install --AUTO {automode} "
    ...
)
@lczech lczech added the bug Something isn't working label May 24, 2021
Copy link
Contributor

github-actions bot commented Mar 1, 2024

This issue was marked as stale because it has been open for 6 months with no activity.

@github-actions github-actions bot added the Stale label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

This issue was closed because it has been inactive for 1 month since being marked as stale. Feel free to re-open it if you have any further comments.

@github-actions github-actions bot closed this as completed Oct 1, 2024
@lczech
Copy link
Author

lczech commented Oct 1, 2024

Thanks, stale bot. I don't think this is solved yet... Your suggestion to re-open also does not work, as apparently I do not have the rights to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants