Skip to content
This repository has been archived by the owner on Feb 1, 2021. It is now read-only.

Github check does not appear #16

Open
skjnldsv opened this issue Oct 2, 2019 · 9 comments
Open

Github check does not appear #16

skjnldsv opened this issue Oct 2, 2019 · 9 comments

Comments

@skjnldsv
Copy link

skjnldsv commented Oct 2, 2019

Hey!

Thanks for your awesome app, looks very promising!
https://github.com/skjnldsv/vueexample/pull/237/checks

Just enabled this, and I can see the results just fine https://app.bundle-analyzer.com/gh/skjnldsv/vueexample
But there is no github checks on my pull requests. Anything I need to do?

@gregberge
Copy link
Member

Everything fine, just make a new pull-request and it should show up.

@skjnldsv
Copy link
Author

skjnldsv commented Oct 2, 2019

I did already, it doesn't :)
skjnldsv/vueexample#261

@skjnldsv
Copy link
Author

skjnldsv commented Oct 2, 2019

@neoziro My guess is the bundle analyzer don't understand it comes from a pull request against master and not a merge.
The result on https://app.bundle-analyzer.com/gh/skjnldsv/vueexample/builds/8 show the branch is master, but it's not.

Capture d’écran_2019-10-02_12-42-34
Capture d’écran_2019-10-02_12-42-40

@skjnldsv
Copy link
Author

skjnldsv commented Oct 2, 2019

Reopen? :)

@gregberge
Copy link
Member

Hello @skjnldsv, so what is the problem exactly? Let's fix it!

@skjnldsv
Copy link
Author

When opening a new pr, there is no GitHub checks for me :/
Do I need to configure something more? :)

Also it looks like all pr are displayed as master commits instead of the current branch of the commit (see previous comment)

@ChristophWurst
Copy link

If I go to https://app.bundle-analyzer.com/gh/nextcloud/mail/builds I see only builds on master, though most are from PRs.
Same wrong info at https://app.bundle-analyzer.com/gh/nextcloud/mail/builds/358

Branch master

Do we miss any configuration? How's the branch determined?

@ChristophWurst
Copy link

Is it maybe because we use an organization? @gregberge have you tested with such a repo?

@gotbahn
Copy link

gotbahn commented Dec 27, 2019

Hey guys, same happens for us. I'm trying to integrate your solution into our organisation. But GitHub checks is stale in waiting status despite finished job.

image

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants