Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some small things #8

Open
smitmartijn opened this issue Nov 27, 2018 · 3 comments
Open

some small things #8

smitmartijn opened this issue Nov 27, 2018 · 3 comments
Assignees

Comments

@smitmartijn
Copy link
Owner

I would like to share with some small things that I added/changed into Your script. I'm using it almost from beginning of my career at Cisco. And changes was done to suite more my needs in case of UCS assessment. After some time finally I'm ready to share and contribute my changes/findings.
Here is summary what I have done, there could be of course some changes which was done and simply forgotten :)

Cisco UCS Inventory Script - v5 (26-11-2018)

Added:

- Corrected UCSM version output

- Corrected Profile Templates and added extended informations

- Added Power Supplies Inventory

- Added Firmware Packages

- Added Catalog Package

- Added extended informations at Service Profile Templates

- Added extended informations at Server Storage Controller Inventory

- Added extended informations at local disks

- Added extended informations at memory modules

- Added extended informations at adapter

- Added vNIC Configuration

- Added Best Effort and FC Qos Class

- QoS Policies and QoS vNIC Policy Map moved to LAN Policies

- Added priviladge for local user information

- Added Disconnect-UCS at beginning

- Added .html at the end of out file

Feel free to reuse/change whatever suites You. Hope that small contribution will be helpful :).
Cheers
UCS_Inventory_v5.zip

Originally posted by @JakubKaminskiPL in #7 (comment)

@smitmartijn smitmartijn self-assigned this Nov 27, 2018
@smitmartijn
Copy link
Owner Author

So this did not work out as I hoped it would...Wanted to simply take your comment and create a new issue @JakubKaminskiPL - Is it possible to create a diff between your version and the one in here, so we can get an accurate account of what's changed?

It would be even better if you could do a pull request. :-)

@JakubKaminskiPL
Copy link

Hi Martijn,

So I'm totally fresh with GitHub. Problem is that I don't even know how to find place where I put the comments and send it to You :). And regarding script I can simply add additional comment into the code so You can easily find what was changed :).

For now this GitHub website is black magic for me, maybe in time I will know it better, but for that I need to find the time :).

@JakubKaminskiPL
Copy link

So like I wrote, here I added a simply comment to lines where I changed something (there could be some places where still I changed something but simply forgot to mark it).
Magical comment is "# JK was here" :).

UCS_Inventory_v5.ps1.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants