Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backward compatibility for setTimeout #168

Open
wezztt opened this issue Jun 10, 2022 · 3 comments
Open

Backward compatibility for setTimeout #168

wezztt opened this issue Jun 10, 2022 · 3 comments

Comments

@wezztt
Copy link

wezztt commented Jun 10, 2022

Hello with 1.4.5 version you've broke backward compatibility for https://github.com/smi2/phpClickHouse/blame/master/src/Client.php#L186

Also please actualize readme examle https://github.com/smi2/phpClickHouse/blame/master/README.md#L66
$db->setTimeout(1.5); // 1 second , support only Int value o_O

Thanks in advance
@xtrime-ru
Copy link
Contributor

Any idea why float was replaced with int? Looks like unnecessary downgrade.

Ive made PR with proper float support: #173
And then found 1.4.5 release notes...

@isublimity
Copy link
Contributor

isublimity commented Aug 9, 2022 •
edited
Loading

Some problem #152
max_execution_time - is integer in clickhouse source - Seconds

M(Seconds, max_execution_time, 0, "", 0) \

@isublimity
Copy link
Contributor

Only setConnectTimeOut & getConnectTimeOut can be float

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@isublimity @wezztt @xtrime-ru