Simultaneously support R4, STU3 and DSTU2 #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the same FHIRClient version to be used with multiple FHIR versions. We have to use a different version of fhir-parser to generate DSTU2 because the latest version dropped support.
Regenerate DSTU2 unit tests with a template that works for 2.7.
|
To review this I would suggest ignoring everything below $ git diff v4.0.0:fhirclient/models HEAD:fhirclient/models/R4
$ git diff v3.0.0:fhirclient/models HEAD:fhirclient/models/STU3
$ git diff v1.0.3:fhirclient/models HEAD:fhirclient/models/DSTU2Also in the github diff settings select Hide whitespace changes |
|
Closing for now, will reopen a smaller initial PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
Generate a models package for R4, STU3 and DSTU2. This allows the same FHIRClient version to be used with multiple FHIR versions.
We have to use a different version of fhir-parser to generate DSTU2 because the latest version dropped support.
Running the tests re-downloads the FHIR specs for each version because fhir-parser doesn't provide a way to cache different versions simultaneously.
This also cleans up the (non-generated) code to make it PEP8 compliant and adds a flake8 test.