Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the version of Badger that matches existing DB files #11

Open
dopey opened this issue Dec 1, 2020 · 2 comments
Open

Use the version of Badger that matches existing DB files #11

dopey opened this issue Dec 1, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@dopey
Copy link
Contributor

dopey commented Dec 1, 2020

What would you like to be added

Default to the version of Badger required by existing DB files

Why this is needed

Rather than forcing the user to select a version of Badger:

  1. Default to the correct version based on existing DB files
  2. If no files exist (new db) then default to the most recent version.
@dopey dopey added enhancement New feature or request needs triage Waiting for discussion / prioritization by team labels Dec 1, 2020
@dopey
Copy link
Contributor Author

dopey commented Dec 1, 2020

V1: 00000000  42 64 67 72 00 00 00 04  00 00 00 00 00 00 00 00  |Bdgr............|
V2: 00000000  42 64 67 72 00 00 00 07  00 00 00 00 00 00 00 00  |Bdgr............|

@maraino
Copy link
Collaborator

maraino commented Dec 3, 2020

At master they are now using version 8, see dgraph-io/badger@e3a0d29 but they haven't yet released a new version of badger with that change, but we should monitor this.

The migration strategy is described here https://github.com/dgraph-io/badger/blob/master/docs/content/faq/index.md#i-see-manifest-has-unsupported-version-x-we-support-y-error. And it should not be hard to create a tool or an automatic process in step-ca to do this, looking at the badger's backup and restore cli commands.

@dopey dopey removed the needs triage Waiting for discussion / prioritization by team label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants