Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download "activity" is registered before format selection #634

Open
katrinleinweber opened this issue Nov 15, 2017 · 7 comments
Open

Download "activity" is registered before format selection #634

katrinleinweber opened this issue Nov 15, 2017 · 7 comments

Comments

@katrinleinweber
Copy link

to reproduce:

  1. open any presentation, e.g. https://slidewiki.org/deck/584-4
  2. click the download button => as expected, the format list pop-up
  3. click somewhere else on the page to close the format list and abort the download => unexpectedly, "... downloaded this deck 0 seconds ago" appears in the "Activity Feed" on the right

Expected: "...downloaded..." appears after starting the download, or maybe even only after it successfully completes.

This behaviour seems to be client-side-only or there is some server-side clean-up, because after refreshing the page, this activity item is gone.

@dpaun
Copy link
Member

dpaun commented Nov 22, 2017

Hi! Thanks for reporting this. We will address this issue soon.

@katrinleinweber
Copy link
Author

Now, the "download" activity is registered after clicking download, even if aborted then.

@dpaun
Copy link
Member

dpaun commented Apr 13, 2018

Hi! Thanks for reporting this.
However, unfortunately, I can not reproduce it (if I cancel the download the activity is not created).

@katrinleinweber
Copy link
Author

slidewiki-premature-dl-activity

I'm seeing this in both Chrome and Firefox, and the "activty" remains in the list even when I load the landing page in a 3rd browser. So, it doesn't appear to be merely a local JavaScript counter, or caching issue.

When one aborts the download modal with the PDF, ePub, etc. radio buttons, then you are right: no download is logged. So, were are one step further from the original issue: Expected: "...downloaded..." appears after starting the download.

I'm just saying that in case your server logs show a handful of "guest" downloads of https://slidewiki.org/deck/584 this morning, there is still a discrepancy to successfully completes, because due to 504 errors, or me closing that tab in which the "Save File to" dialog would have appeared, none of those "downloads" correspond with data actually streaming into a file on my hard drive.

@dpaun
Copy link
Member

dpaun commented Apr 13, 2018

I understand now. This is indeed an issue. Thanks for clarifying it.

@katrinleinweber
Copy link
Author

You're welcome :-)

@katrinleinweber
Copy link
Author

Any news on this? I tried it just now in Chrome 68.0.3440.106 & this still happens, just as above (Firefox 61.0.2 by now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants