Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No consistent language on the page (BITV 3.1.1a) #1159

Open
VivienDZB opened this issue Apr 4, 2019 · 7 comments
Open

No consistent language on the page (BITV 3.1.1a) #1159

VivienDZB opened this issue Apr 4, 2019 · 7 comments
Assignees
Labels
iOCW Issue was created/worked on during iOCW project

Comments

@VivienDZB
Copy link
Contributor

A lot of text is still hard-coded in the system. Additionally, not all translation strings are translated.

@VivienDZB VivienDZB changed the title No consistent language on the page No consistent language on the page (BITV 1.1.1a) Apr 4, 2019
@bwulff bwulff added the iOCW Issue was created/worked on during iOCW project label Apr 4, 2019
@aoelen
Copy link
Member

aoelen commented Apr 26, 2019

This is indeed true. Can you tell me the importance of this task? It requires a lot of work to: firstly ensure that all text is translatable, and secondly to actually translate the text. Maybe it makes sense to list the pages where it is most important to have a full (German) translation.

@VivienDZB
Copy link
Contributor Author

Maybe it would be reasonable to concentrate on the main functions of SW first. For me that would definitely be the editor, the search for slides and the home page.

@aoelen
Copy link
Member

aoelen commented Jul 10, 2019

Currently Reza is working on this task. @rezatavakoli, can you tell which pages are now translatable?

@VivienDZB Can you identify where translations are missing, so we can continue working on this task? Maybe its helps by mentioning the 'page ID', which is now listed on: https://github.com/slidewiki/slidewiki-platform/wiki/List-of-pages In case a page is missing, you are welcome to add it to the list. Thanks!

@rezatavakoli
Copy link
Collaborator

rezatavakoli commented Jul 10, 2019 via email

@aoelen
Copy link
Member

aoelen commented Jul 29, 2019

PR #1188 is merged. Of course there are still some missing translations in the system, so I think it's best to leave the ticket open (and add comments when some untranslated text is found).

@VivienDZB VivienDZB changed the title No consistent language on the page (BITV 1.1.1a) No consistent language on the page (BITV 3.1.1a) Feb 17, 2020
@aoelen
Copy link
Member

aoelen commented Nov 13, 2020

@rezatavakoli In PR #1285 I made the page title translatable. Can you do a final check of the platform to see if there is any text left that cannot be translated? Thanks!

@aoelen
Copy link
Member

aoelen commented Nov 13, 2020

You can maybe use issue #1238 as a hint to find pages with non-translated text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOCW Issue was created/worked on during iOCW project
Projects
None yet
Development

No branches or pull requests

4 participants