-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearer readme/docs #130
Comments
@mikearnaldi, quoted from the slack channel (link to join here - channel
|
summoner naming has been updated in the Readme |
first of all, thank you for creating this library. It would be nice if there was some sort of conceptual guide to explain the big picture behind the library. The README is more instructional/FAQ, which is of great importance also of course. What I mean is actually already there - the "How it works" section, but it is rather short. Also, some sort of comparative overview that lists what The biggest question for me is: If I have an existing domain model with lots of existing At the moment I don't need really this library, what |
Also more info on
Whats unclear in docs: why do I need newtype-ts, io-ts-types? What is clear, probably need fast-equals, when using fast-check, right? Can I ignore it, when not using fast-check summoner? Even when I add the peerDependencies expected in my root, I still get warnings from the other You really should add more than just "install @morphic-ts/batteries" in the docs, when using what feature, what is needed or if something is always needed, then you should add it in the docs too |
IMHO: The docs explain well, what the purpose of the library is. Have 1 definition and generate different things, like lenses (monocle-ts), codecs (io-ts) and more out of it. But then the docs go about information as if you already know everything. I know for example the Don't get me wrong. I don't write it as some sort of expectation, its a free project, just in case you are not aware of it. If you just don't have the time for "full" docs, I guess then that's how it is. But sometimes if you know stuff, you've wrote, you don't realize "holes" in the explanation, because for you personally there is no hole ;P |
I saw your articles on Dev.to and they were very cool. However, I'm finding it difficult to locate the variables and types needed for the configuration of summoners. I would really love to get some insight those. |
First of all: great job.
This project seems so useful and interesting and I would use it right now, but the readme/documentation it's a bit confusing to me: what is the meaning of
BASTJ
andESBASTJ
suffixes in thebatteries
package?I think that the
summoner
and config parts should be a little clearer...Maybe you can also use the
gcanti/docs-ts
packageThe text was updated successfully, but these errors were encountered: