Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] python 3.13 compatibility #1690

Open
fkiraly opened this issue Oct 2, 2024 · 2 comments · May be fixed by #1691
Open

[MNT] python 3.13 compatibility #1690

fkiraly opened this issue Oct 2, 2024 · 2 comments · May be fixed by #1691
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Oct 2, 2024

We should test 3.13 compatibility on the release candidate rc3, and prepare for the release on 3.13 on Oct 7.

I foresee no compatibility issues as long as the dependencies keep up with 3.13.

The main issue may be numpy, of which we still require version 1, see #1624 - any chance we can resolve this, @XinyuWuu?

Perhaps just not supporting numpy 2 on mac x86?

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Oct 2, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 3, 2024

The numpy 2 issue is resolved by moving to macos-latest.

@XinyuWuu
Copy link
Member

XinyuWuu commented Oct 4, 2024

Perhaps just not supporting numpy 2 on mac x86?

It's the only solution I think. If users wants numpy2 and torch on mac x86, they can try to compile torch locally but it's guaranteed by pytorch.

@fkiraly fkiraly linked a pull request Oct 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants