New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positives on low-zoom and/or high-pixel-ratio #34

Open

steevee opened this issue May 3, 2019 · 0 comments

steevee commented May 3, 2019

Steps to replicate

Go to https://fuckadblock.sitexw.fr/blockadblock/ without an adblocker enabled on Chrome (v70+)
Ensure browser zoom level is 100% and note value of window.devicePixelRatio
If window.devicePixelRatio == 1 then zoom out to 33% and refresh page.
- Outcome: AdBlocker detected
- Desired: AdBlocker should not be detected
- N.b. If window.devicePixelRatio > 1 (i.e. testing on a retina screen) zoom level and window dimensions may differ slightly to above.

Technical issue

The above steps mean this._var.bait.offsetHeight, this._var.bait.offsetWidth, this._var.bait.clientHeight, this._var.bait.clientWidth all equal zero and flag detected.

The text was updated successfully, but these errors were encountered:

steevee pushed a commit to steevee/BlockAdBlock that referenced this issue


          Zoom false-positive fix for sitexw#34.

98e5eca

Increasing bait dimensions fixes the issue, and as bait is placed off screen this shouldn't impact usability

steevee added a commit to steevee/BlockAdBlock that referenced this issue


          Merge pull request #1 from steevee/34-zoom-false-positives

a7158fa

Zoom false-positive fix for sitexw#34.

steevee pushed a commit to steevee/BlockAdBlock that referenced this issue


          Increased bait dimensions further based on @sitexw feedback. Related to

ffda427

sitexw#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment