Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect output for repeated qualified fields #3

Open
ewencp opened this issue Aug 23, 2012 · 0 comments
Open

Incorrect output for repeated qualified fields #3

ewencp opened this issue Aug 23, 2012 · 0 comments

Comments

@ewencp
Copy link
Member

ewencp commented Aug 23, 2012

If you import another pbj file and then try to use one of its messages as a repeated field, e.g.:

import "Loc.pbj";
message foo {
    optional Sirikata.Protocol.Loc.BulkLocationUpdate loc_update = 2;
}

it generates bad output like this:

        Sirikata::Protocol::Loc::LocationUpdate IPintoResponse::loc_update(int index) const {
            return Sirikata::Protocol::Loc::LocationUpdate(*const_cast<_Protocol_::Sirikata.Protocol.Loc.LocationUpdate*>(&super->loc_update(index)));
        }

where the names are not properly converted. There's a bunch of if blocks selecting based on "isMultiplicitiveAdvancedType" (which I am not sure what it even indicates), "isRepeated", and "isMessage"/"isSubmessage". I think they all generate correct code, but maybe we're not setting one of the flags correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant