Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization issue with Image picker menu popup #2335

Open
1 task done
AlexBeehave opened this issue Oct 25, 2024 · 0 comments
Open
1 task done

Localization issue with Image picker menu popup #2335

AlexBeehave opened this issue Oct 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@AlexBeehave
Copy link

Is there an existing issue for this?

Flutter Quill version

10.8.4

Steps to reproduce

  1. Create a Flutter toolbar editor with a French Locale:
    QuillToolbar.simple(
    controller: _controller,
    configurations: QuillSimpleToolbarConfigurations(
    showCodeBlock: false,
    showSearchButton: false,
    showFontFamily: false,
    embedButtons: FlutterQuillEmbeds.toolbarButtons(),
    sharedConfigurations: QuillSharedConfigurations(
    locale: const Locale('fr'),
    ),
    ),
    )
  2. Start your quill editor with toolbar

Expected results

The image and video caption button should be both in French.
The imagePicker menu should be in French.

Actual results

Only the image button caption is in French.
The imagePicker menu is in English.
Screenshot_20241025_220952
Screenshot_20241025_220907
Screenshot_20241025_220819

Additional Context

Debug analysis

The context when the class SelectImageSourceDialog is build is in English. There seems to be a disruption between the context given in the toolbar button and the context given to the popup.
builder: (_) => const FlutterQuillLocalizationsWidget(
child: SelectImageSourceDialog(),
),

Not sure exactly why...

@AlexBeehave AlexBeehave added the bug Something isn't working label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant