New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask OAuth credentials #82

Open

JCotton1123 opened this issue May 1, 2020 · 0 comments

JCotton1123 commented May 1, 2020

OAuth credentials are logged by default, example:

[2020-05-01T03:37:16.155Z] INFO Attempting login via OAuth2
[2020-05-01T03:37:16.171Z] INFO Making POST request to https://login.salesforce.com/services/oauth2/token with body {'grant_type': 'refresh_token', 'client_id': '...', 'client_secret': '...', 'refresh_token': '...'}
[2020-05-01T03:37:16.185Z] INFO OAuth2 login successful

Would you accept a PR to address this? Possibly by adding a parameter to, https://github.com/singer-io/tap-salesforce/blob/master/tap_salesforce/salesforce/__init__.py#L272, to mask the body, and updating, https://github.com/singer-io/tap-salesforce/blob/master/tap_salesforce/salesforce/__init__.py#L306, appropriately?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment