Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--properties is not deprecated, --catalog doesn't work #84

Open
mattarderne opened this issue Feb 11, 2019 · 4 comments
Open

--properties is not deprecated, --catalog doesn't work #84

mattarderne opened this issue Feb 11, 2019 · 4 comments

Comments

@mattarderne
Copy link

mattarderne commented Feb 11, 2019

This is pretty minor, but overlooked it

When using --catalog param with catalog.json file, I get the below notice
INFO No properties were selected

When using --properties, it works, however --properties is marked as deprecated by --help as below:

  -p PROPERTIES, --properties PROPERTIES
                        Property selections: DEPRECATED, Please use --catalog
                        instead
  --catalog CATALOG     Catalog file
mdimercurio added a commit to dialoguemd-archives/tap-hubspot that referenced this issue Jun 1, 2019
@pranaygp
Copy link

using --properties and passing in a catalog with selected streams still doesnt work for me 🤔

@pranaygp
Copy link

pranaygp commented Aug 27, 2019

If you're here because you're not able to pass in a catalog correctly, you'll want to use --properties and change your catalog file. I found the difference between properties.json and catalog.json in this old commit here: https://github.com/singer-io/getting-started/blob/5182006a2bbe542d4e94e53ddc18b59c86fcd8a2/docs/SYNC_MODE.md#legacy-streamfield-selection

@patrykkalinowski
Copy link

@pranaygp does it work for you? I have streams selected according to your link, but tap outputs this:

INFO Starting sync. Will sync these streams: []
INFO Sync completed

My catalog.json:

( ... )
"stream": "contacts",
            "tap_stream_id": "contacts",
            "schema": {
                "type": "object",
                "selected": true,
                "properties": {
( ... )

@patrykkalinowski
Copy link

OK, nevermind guys. I had to use singer-discover:
tap-hubspot/bin/tap-hubspot -c tap-hubspot/config.json --discover | singer-discover -o tap-hubspot/catalog.json

It helped me with proper catalog setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants