Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental mode duplicates last record (deals) #161

Open
slumbi opened this issue Aug 27, 2021 · 0 comments
Open

Incremental mode duplicates last record (deals) #161

slumbi opened this issue Aug 27, 2021 · 0 comments

Comments

@slumbi
Copy link

slumbi commented Aug 27, 2021

In case of deals (but I think it is true for other entities as well):
When running the tap with a state file, comparison based on hs_lastmodifieddate is buggy, and the last record of the previous execution is exported again during the next execution.
I think the culprit is in this line :

            if not modified_time or modified_time >= start:
                record = bumble_bee.transform(lift_properties_and_versions(row), schema, mdata)
                singer.write_record("deals", record, catalog.get('stream_alias'), time_extracted=utils.now())

I guess modified_time should be strictly greater ( > ) than start in order to not write out again the same record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant