Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit specific property value specification in catalog #121

Open
jthele opened this issue Jul 23, 2020 · 0 comments
Open

Permit specific property value specification in catalog #121

jthele opened this issue Jul 23, 2020 · 0 comments

Comments

@jthele
Copy link

jthele commented Jul 23, 2020

Referencing this line of code in has_selected_custom_field:

https://github.com/singer-io/tap-hubspot/blob/master/tap_hubspot/__init__.py#L488

Specifically, the len(x) == 2 conditional.

If all of my requests for property values in the catalog are very specific, like this:

        {
          "breadcrumb": [
            "properties",
            "property_hs_lastmodifieddate",
            "properties",
            "value"
          ],
          "metadata": {
            "selected": true
          }
        },

That conditional will result in me getting no properties at all. A very simple fix would be to replace with len(x) >= 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant