Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return exit code 0 on failure #116

Open
GuillaumeDesforges opened this issue Dec 10, 2020 · 0 comments
Open

Return exit code 0 on failure #116

GuillaumeDesforges opened this issue Dec 10, 2020 · 0 comments

Comments

@GuillaumeDesforges
Copy link

Description of the bug

Calling CLI tap-facebook returns exit code 0 even when it fails.

Expected behavior

Failed call should return exit code 1.

This is important for instance when calling the tool from airflow: airflow thinks the task succeeded when it did not.

Investigation

This is caused by litl/backoff#72

Proposal

Set on_giveup to a function raising an exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set on_giveup in backoff to reraise Exception
1 participant
@GuillaumeDesforges