Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--catalog vs -p (properties) parameters #70

Open
chrisb-c01 opened this issue Apr 11, 2018 · 4 comments
Open

--catalog vs -p (properties) parameters #70

chrisb-c01 opened this issue Apr 11, 2018 · 4 comments

Comments

@chrisb-c01
Copy link

It might be me, but the use of the --catalog and property -p parameters is somewhat unclear to me.

They are used intermixed throughout different sections of the docs (e.g. Allowing Users to Select Streams to Sync vs. Sync mode).

Source code mentions -p to be deprecated over --catalog, however replacing -p by --catalog leads to different behaviour: the "selected": true on a schema definition in the catalog file is not honoured by --catalog, but is by -p parameter.

It would be helpful if this could be clarified a bit more in the docs.

@briansloane
Copy link

Thanks for the feedback, @ChrisCalculus. As you noted, the -p- is deprecated in favor of using the --catalog. We're shifting towards usage of metadata in the catalog for noting which fields should be selected. We agree that the documentation needs some work and plan to address that in the future. We'll update here when that happens.

@chrisb-c01
Copy link
Author

Thanks for replying @briansloane. Looking forward to the update.

@pedromachados
Copy link

Any plans to change the transform function to respect the selected setting?

@briansloane
Copy link

@pedromachados No plans to do that as of now. I'd recommend creating another issue to outline this request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants