Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments layout broken (isn't contained within given layout space) #250

Open
clarkepaul opened this issue May 21, 2018 · 4 comments
Open

Comments

@clarkepaul
Copy link
Contributor

Several layout issues for the comments module when in split-mode.
NOTE these might be Grid Field issues, if so move to silverstripe-admin.

  • The table of comments isn't responsive to the given space
  • Search opens in the wrong place (should be between table header and body)
  • Several action layout issues

pasted_image_at_2018_05_21_03_56_pm

@robbieaverill
Copy link
Contributor

It's fairly likely that this could be related to GridFieldBulkEditingTools, which isn't released as stable for SS4 yet. We have some work to do to upgrade our use of its API in this module before we release CWP 2.1 (ideally).

@robbieaverill
Copy link
Contributor

Allegedly fixed with silverstripe/silverstripe-admin#527

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Sep 8, 2018

It's not fixed with silverstripe/silverstripe-admin#527 - that issue just addressed the menu bar at the top that would overflow over the preview.

@ScopeyNZ ScopeyNZ reopened this Sep 8, 2018
@Cheddam
Copy link
Member

Cheddam commented Mar 21, 2019

Current state of this issue:

  • The table of comments isn't responsive to the given space
    • The column shown on mobile, 'Submitted By', might not be ideal.
    • We don't collapse any columns at other breakpoints. The comment contents column in particular can get very compressed, so this needs to be addressed. There are no core APIs for this right now, but some injected CSS might suffice.
  • Search opens in the wrong place (should be between table header and body)
    • The new Search UI in a recent release of SilverStripe 4 somewhat mitigates this - it makes a bit more sense to render where it does. Could still use a review, though.
  • Several action layout issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants