Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where any old signature can be used #58

Open
Stentonian opened this issue Jul 17, 2024 · 0 comments
Open

Fix bug where any old signature can be used #58

Stentonian opened this issue Jul 17, 2024 · 0 comments
Labels
effort:much Difficult task priority:high Task is important and needs to get done asap security Related to security of the protocol

Comments

@Stentonian
Copy link
Contributor

Stentonian commented Jul 17, 2024

At the moment it's possible to just insert any old signatures. One could even grab existing signatures from past transactions; the verifier would not be able to tell the difference. This means the protocol is broken, in a sense, because the prover does not need to have access to the private key of an address in order to claim it's funds. There are a few possible ways to resolve this:

  1. Use private keys as inputs to the snark (instead of signatures) - this is largely incompatible with custodian's internal systems since their private keys are locked behind specialized wallet software
  2. Expose the signature message as a public signal in the snark system - this will allow the verifier to check that it contains sufficient randomness (such as the block hash at some time)
  3. Use transactions as input to the snark Use transactions as input to the snarks, as opposed to signatures #57
@Stentonian Stentonian added effort:much Difficult task priority:high Task is important and needs to get done asap security Related to security of the protocol labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:much Difficult task priority:high Task is important and needs to get done asap security Related to security of the protocol
Projects
None yet
Development

No branches or pull requests

1 participant