Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy Controller does not support deployment strategy values #748

Open
shearn89 opened this issue May 7, 2024 · 0 comments · May be fixed by #749
Open

Policy Controller does not support deployment strategy values #748

shearn89 opened this issue May 7, 2024 · 0 comments · May be fixed by #749
Labels
enhancement New feature or request

Comments

@shearn89
Copy link

shearn89 commented May 7, 2024 •
edited
Loading

Description

Looking at the charts for the policy-controller webhook, it does not seem possible to pass in values for the deployment strategy. Specifically things like maxSurge?

My actual problem:

I'm unable to drain a node because I've got policy-controller deployed with replicas: 1, and the default deployment strategy won't let it surge to 2 in order to roll, because the maxSurge defaults to 25% rounded down, i.e. 0.

What I'd like to do:

  • Configure the deployment strategy same as other templates.
@shearn89 shearn89 added the enhancement New feature or request label May 7, 2024
shearn89 added a commit to shearn89/helm-charts that referenced this issue May 7, 2024
@shearn89
Expose the deployment strategy values for the policy controller
a14276d 
Prior to this change, the policy controller webhook was not able to have
its deployment strategy modified. If you only deployed a single replica,
it could not perform a rolling update due to the default `maxSurge:
25%` being rounded down to 0.

This change exposes those values, so that the `maxSurge` can be updated
and a single instance can be rolled.

Fixes sigstore#748.
@shearn89 shearn89 linked a pull request May 7, 2024 that will close this issue
Open
4 tasks
shearn89 added a commit to shearn89/helm-charts that referenced this issue May 7, 2024
@shearn89
Expose the deployment strategy values for the policy controller
30f3e6e 
Prior to this change, the policy controller webhook was not able to have
its deployment strategy modified. If you only deployed a single replica,
it could not perform a rolling update due to the default `maxSurge:
25%` being rounded down to 0.

This change exposes those values, so that the `maxSurge` can be updated
and a single instance can be rolled.

Fixes sigstore#748.

Signed-off-by: Alex Shearn <[email protected]>
shearn89 added a commit to shearn89/helm-charts that referenced this issue May 8, 2024
@shearn89
Expose the deployment strategy values for the policy controller
5505f6d 
Prior to this change, the policy controller webhook was not able to have
its deployment strategy modified. If you only deployed a single replica,
it could not perform a rolling update due to the default `maxSurge:
25%` being rounded down to 0.

This change exposes those values, so that the `maxSurge` can be updated
and a single instance can be rolled.

Fixes sigstore#748.

Signed-off-by: Alex Shearn <[email protected]>
shearn89 added a commit to shearn89/helm-charts that referenced this issue Oct 10, 2024
@shearn89
Expose the deployment strategy values for the policy controller
5d739b5 
Prior to this change, the policy controller webhook was not able to have
its deployment strategy modified. If you only deployed a single replica,
it could not perform a rolling update due to the default `maxSurge:
25%` being rounded down to 0.

This change exposes those values, so that the `maxSurge` can be updated
and a single instance can be rolled.

Fixes sigstore#748.

Signed-off-by: Alex Shearn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose the deployment strategy values for the policy controller shearn89/helm-charts
1 participant
@shearn89