Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the attachment status is set to "TRANSFER_PROGRESS_PERMANENT_FAILURE," no dialog is displayed on conversation view. #13722

Open
4 tasks done
abdlkdrisiktan opened this issue Oct 3, 2024 · 0 comments

Comments

@abdlkdrisiktan
Copy link

abdlkdrisiktan commented Oct 3, 2024


Bug description

I manually set the attachment's status to TRANSFER_PROGRESS_PERMANENT_FAILURE, but no dialog is displayed in the conversation fragment. Instead, it only shows up in the conversationList when returning to the main conversation view. From a user experience perspective, this is problematic because the user is left unaware of the failure or issue in real-time, which can lead to confusion. Ideally, there should be a clear notification or dialog within the conversation window to inform the user about the failed attachment status immediately.

Steps to reproduce

  • send attachment with "TRANSFER_PROGRESS_FAILED" status
  • go to AttachmentDownloadJob.kt
  • change "private fun markFailed(messageId: Long, attachmentId: AttachmentId)" function inside with "SignalDatabase.attachments.setTransferProgressPermanentFailure(attachmentId, messageId)"
  • open conversation view
  • tap the attachment
  • try to download but couldn't download
  • dialog creating in ConversationItem.java
  • press back button
  • back to conversationList fragment
  • Dialog will displayed on conversationListFragment.

Actual result:
Expected result: Dialogs should be displayed in conversation view. Not the conversationListFragment.

Screenshots

Device info

Device: Manufacturer Model XVI
Android version: 0.0.0
Signal version: 0.0.0

Link to debug log

@abdlkdrisiktan abdlkdrisiktan changed the title When the attachment status is set to "TRANSFER_PROGRESS_PERMANENT_FAILURE," no dialog is displayed. When the attachment status is set to "TRANSFER_PROGRESS_PERMANENT_FAILURE," no dialog is displayed on conversation view. Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant