Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

Make branch: magit-gh-pulls-create-branch #89

Open
bobot opened this issue Apr 14, 2016 · 1 comment
Open

Make branch: magit-gh-pulls-create-branch #89

bobot opened this issue Apr 14, 2016 · 1 comment

Comments

@bobot
Copy link

bobot commented Apr 14, 2016

Perhaps I don't understand the goal of Make branch, but I think it is very strange that it asks for a base branch and that it merge the commit of the PR in this branch. I would expect at the end of Make branch to have exactly the same tip commit than the one on github.

For that, I see two possibilities:

  1. the merge :sha should be replaced by a reset --hard :sha
  2. directly git checkout branch :sha, that remove the need for asking for a base branch.
@raxod502
Copy link

@sigma I just ran into this. Has there been any update here? It seems like the current functionality directly contradicts the description of # b in the README:

create a topic branch for this PR. After testing the PR you can merge it back into your branch using Magit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants