Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

Selecting a PR in PR list complains about missing magit-section-value symbol #131

Open
c3d opened this issue Oct 22, 2020 · 3 comments
Open

Comments

@c3d
Copy link

c3d commented Oct 22, 2020

Steps to reproduce:

  • Select a repository
  • Fetch the PR list
  • Select a PR
  • Hit return, apparently bound to magit-gh-pulls-fetch-commit

Expected result:

Shows the PR that was selected

Observed result

Fails with message

magit-gh-section-req-data: Symbol’s function definition is void: magit-section-value
@c3d
Copy link
Author

c3d commented Oct 22, 2020

This appears to be a problem with 0.5.3 as bundled on melpa. Checking out master and using that seems to hit different problems, but that (message Contacting host: api.github.com:443 and stuck there).

@c3d
Copy link
Author

c3d commented Oct 22, 2020

At least # o does the right thing and shows the PR in a browser.

@c3d
Copy link
Author

c3d commented Oct 22, 2020

Apparently, on some PRs, it does something sensible, which is to show the diffs. Does not exactly show the PR itself, but at least, that's no longer in the "bugs" category.

On some other PRs, it does not do anything sensible that I can tell.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant