Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

Documented INCLUDE_METAL_SOURCES option for standalone does nothing #595

Open
thestr4ng3r opened this issue Apr 20, 2021 · 0 comments
Open

Comments

@thestr4ng3r
Copy link

Documented here:
https://github.com/sifive/freedom-e-sdk/tree/badc53934a495d6d5c8454b9a4d752d8b7e274a5#create-a-standalone-project

But the variable is never used anywhere:

florian-macbook:freedom-e-sdk florian$ grep INCLUDE_METAL_SOURCES -r .
./README.md:make [PROGRAM=hello] [TARGET=sifive-hifive1] [INCLUDE_METAL_SOURCES=1] STANDALONE_DEST=/path/to/desired/location standalone

In particular, the standalone target always unconditionally copies freedom-metal here:

freedom-e-sdk/Makefile

Lines 381 to 382 in badc539

cp -r freedom-metal $</
find $</freedom-metal -name ".git*" | xargs rm -rf

or here:

freedom-e-sdk/Makefile

Lines 474 to 475 in badc539

cp -r freedom-metal $</
find $</freedom-metal -name ".git*" | xargs rm -rf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant