Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multipath-tools #124

Open
andrewrynhard opened this issue May 26, 2020 · 5 comments
Open

Add multipath-tools #124

andrewrynhard opened this issue May 26, 2020 · 5 comments

Comments

@andrewrynhard
Copy link
Member

No description provided.

@kvaps
Copy link
Contributor

kvaps commented Jul 22, 2023

Heya @andrewrynhard!
I wish to enable dm-thin-pool (LVM thin) module for linstor. And I'm looking for the best way to do this.

What do you think about enabling all those CONFIG_DM_THIN_PROVISIONING, CONFIG_DM_MULTIPATH, CONFIG_DM_CACHE and pack ko's into separate device-mapper-pkg?

pkgs/kernel/build/config-amd64

Lines 2258 to 2284 in d0eaedc

# CONFIG_DM_DEBUG is not set
CONFIG_DM_BUFIO=y
# CONFIG_DM_DEBUG_BLOCK_MANAGER_LOCKING is not set
# CONFIG_DM_UNSTRIPED is not set
CONFIG_DM_CRYPT=y
CONFIG_DM_SNAPSHOT=y
# CONFIG_DM_THIN_PROVISIONING is not set
# CONFIG_DM_CACHE is not set
# CONFIG_DM_WRITECACHE is not set
# CONFIG_DM_EBS is not set
# CONFIG_DM_ERA is not set
# CONFIG_DM_CLONE is not set
CONFIG_DM_MIRROR=y
# CONFIG_DM_LOG_USERSPACE is not set
CONFIG_DM_RAID=m
CONFIG_DM_ZERO=y
# CONFIG_DM_MULTIPATH is not set
# CONFIG_DM_DELAY is not set
# CONFIG_DM_DUST is not set
# CONFIG_DM_INIT is not set
# CONFIG_DM_UEVENT is not set
# CONFIG_DM_FLAKEY is not set
# CONFIG_DM_VERITY is not set
# CONFIG_DM_SWITCH is not set
# CONFIG_DM_LOG_WRITES is not set
# CONFIG_DM_INTEGRITY is not set
# CONFIG_DM_AUDIT is not set

@frezbo
Copy link
Member

frezbo commented Jul 22, 2023

Heya @andrewrynhard! I wish to enable dm-thin-pool (LVM thin) module for linstor. And I'm looking for the best way to do this.

What do you think about enabling all those CONFIG_DM_THIN_PROVISIONING, CONFIG_DM_MULTIPATH, CONFIG_DM_CACHE and pack ko's into separate device-mapper-pkg?

pkgs/kernel/build/config-amd64

Lines 2258 to 2284 in d0eaedc

# CONFIG_DM_DEBUG is not set
CONFIG_DM_BUFIO=y
# CONFIG_DM_DEBUG_BLOCK_MANAGER_LOCKING is not set
# CONFIG_DM_UNSTRIPED is not set
CONFIG_DM_CRYPT=y
CONFIG_DM_SNAPSHOT=y
# CONFIG_DM_THIN_PROVISIONING is not set
# CONFIG_DM_CACHE is not set
# CONFIG_DM_WRITECACHE is not set
# CONFIG_DM_EBS is not set
# CONFIG_DM_ERA is not set
# CONFIG_DM_CLONE is not set
CONFIG_DM_MIRROR=y
# CONFIG_DM_LOG_USERSPACE is not set
CONFIG_DM_RAID=m
CONFIG_DM_ZERO=y
# CONFIG_DM_MULTIPATH is not set
# CONFIG_DM_DELAY is not set
# CONFIG_DM_DUST is not set
# CONFIG_DM_INIT is not set
# CONFIG_DM_UEVENT is not set
# CONFIG_DM_FLAKEY is not set
# CONFIG_DM_VERITY is not set
# CONFIG_DM_SWITCH is not set
# CONFIG_DM_LOG_WRITES is not set
# CONFIG_DM_INTEGRITY is not set
# CONFIG_DM_AUDIT is not set

Yes extra packages loadable as extensions are welcome

@bernardgut
Copy link
Contributor

bernardgut commented May 6, 2024

@kvaps did you manage to make this work ? I have been successfully testing Talos/Linstor on LVM, ZFS and ZFSTHIN for a couple of weeks now, but I couldn't make LVMTHIN work OOB.
Either through the operator :

Error message:                      Failed to create lvm volume

ErrorContext:
  Details:     Command 'lvcreate --config 'devices { filter=['"'"'a|/dev/sdb|'"'"','"'"'r|.*|'"'"'] }' -l 100%FREE -T -n vg1/thin' returned with exitcode 3. 

Standard out: 


Error message: 
modprobe: FATAL: Module dm-thin-pool not found in directory /lib/modules/6.6.28-talos
  /sbin/modprobe failed: 1
  thin-pool: Required device-mapper target(s) not detected in your kernel.
  Run `lvcreate --help' for more information.

Or manually (modified node-shell) :

/ # lvm lvcreate -v --config 'devices { filter=['"'"'a|/dev/sdb|'"'"','"'"'r|.*|'"'"'] }' -l 100%FREE -T -n vg1/thin
  Reloading config files
  Executing: /toolchain/bin/modprobe dm-thin-pool
  /toolchain/bin/modprobe: execvp failed: No such file or directory
  /toolchain/bin/modprobe failed: 2
  thin-pool: Required device-mapper target(s) not detected in your kernel.
  Reloading config files
  Run `lvcreate --help' for more information.
/ # modprobe dm-thin-pool
modprobe: can't load module dm_bio_prison (kernel/drivers/md/dm-bio-prison.ko): Operation not permitted

@kvaps
Copy link
Contributor

kvaps commented May 7, 2024

I didn't use lvmthin with Talos yet, but we use ZFS, which works perfectly. And traditional LVM when we need a high performance

@bernardgut
Copy link
Contributor

I am doing the same. I wanted to test LVMTHIN because I need velero to work on every storageclass. How did you handle backups for LVM (thick)?

BTW I figured it out: For anyone looking at this thread in the future, You need to load the dm-thin-pool kernel module in machine.kernel.modules (Talos).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants