-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The way to determine tcp/unix may be not so right. #1
Comments
I see some other apps use above way to select tcp network and don't think it is a big problem because the config address is set by yourself, if you set invalid, dial will be error, you will be responsible for your configuration. Thanks you! |
Yeah, I see. It's really the user's responsibility to do that. Maybe I just want to make everything right as possible as i can. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Take a look at this:
When
cfg.Addr
equals to./server.sock
, everything is ok. But what happen whencfg.Addr
isserver.sock
? Absolutely, something goes wrong.I notice that, when
net.ResolveTCPAddr
returns an error, then we can saycfg.Addr
is aunix
addressThanks!
The text was updated successfully, but these errors were encountered: