From c05a5b951ec739598ee9623b785c9df9de9acc98 Mon Sep 17 00:00:00 2001 From: Ayush Shukla Date: Thu, 3 Aug 2023 16:42:48 +0200 Subject: [PATCH] feat: create a new from_raw_limbs fn --- src/prime_field.nr | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/prime_field.nr b/src/prime_field.nr index d249d80..53e281e 100644 --- a/src/prime_field.nr +++ b/src/prime_field.nr @@ -42,11 +42,17 @@ impl PrimeField { /////////////////////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////////////////////// - // TODO: Emphasize that there's no montgomery mul here. - fn from_limbs(limbs: [u56; NUM_LIMBS]) -> Self { + // No montgomery mul here. + fn from_raw_limbs(limbs: [u56; NUM_LIMBS]) -> Self { Self { val: BigUint56{ limbs } } } + fn from_limbs(limbs: [u56; NUM_LIMBS]) -> Self { + let tmp = Self { val: BigUint56{ limbs } }; + + tmp.mul(PrimeField::R2()) + } + fn from_u56(val: u56) -> Self { let tmp = Self { val: BigUint56::from_u56(val) };