You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default behavior of markdown to html is to parse image dimensions despite options.parseImgDimensions being false, i.e. with the default options, the following markdown is valid, and converts to the following html:
Because the important point to note here is that if we're setting parseImgDimensions to false that means we want the image to be displayed in its original dimensions regarding of the dimensions provided in the markdown syntax.
Note, we still want the image to be displayed but, not with the dimension attributes.
And the fix you've provided here #985 (which is highly appreciated) does not let the image render rather it just puts the markdown syntax in its place which is not the desired behaviour of a markdown to html converter.
I hope you'll look into it and you'll try to come up with a different approach.
Problem Description
The default behavior of markdown to html is to parse image dimensions despite
options.parseImgDimensions
beingfalse
, i.e. with the default options, the following markdown is valid, and converts to the following html:The Fix
Fixing this issue requires two things in my opinion:
true
both in code and in the documentation.false
image dimensions should be rejectedDesired behavior with
parseImgDimensions
set tofalse
The above markdown should be rejected as valid image markdown and converted to the following html:
The text was updated successfully, but these errors were encountered: