Furoshiki tests make actual HTTP requests

[PragTob]

The tests seem to make real HTTP requests, which is not always the best way to handle things. Maybe we should think about using something like the vcr/vcr gem.

[PragTob]

This of course here is somewhat related to #5

[plexus]

On 24.06.2013 12:00, Tobias Pfeiffer wrote:

The tests seem to make real HTTP requests, which is not always the
best way to handle things. Maybe we should think about using something
like the vcr/vcr gem.

—
Reply to this email directly or view it on GitHub
#4.

What service is it calling? I've worked with VCR before, it's pretty
cool but if the interactions aren't too complex I prefer to write a
test/mock service.

[PragTob]

Well in that case it is downloading a huge ass zip file... see #5 - maybe for tests we should take that from the local file system (I think it does so after the first test run) however that's not so cool for Travis.

On the other hand the real request is also cool, as it makes us notice if the URL is broken during test runs... so umm as always lots of viable options :-)

[wasnotrice]

What would I do without you two to keep me honest? :)

I'd like to find some solution that does test the whole process end-to-end, but that maybe allows us to skip the actual download on Travis runs. As we add packaging options, the number of potential downloads will increase.

Maybe that end-to-end spec would be something we run locally before pushing to Travis, but not on Travis? We could also have a spec that checks for the existence of the necessary URLs without downloading files (HEAD requests?). This would still require the network, but not much, and it's a nice documentation of the URLs we need to be available.

I don't know enough about Travis to propose a solution for handling that large file. It seems like if we need to use a file, we will have to download it, unless Travis offers us a place to host it.