Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE flickering bug #431

Open
windmaomao opened this issue May 1, 2018 · 0 comments
Open

IE flickering bug #431

windmaomao opened this issue May 1, 2018 · 0 comments

Comments

@windmaomao
Copy link

IMPORTANT: Please provide a sample using: http://plnkr.co/edit/lV7zsw7Yqossgs9JOfQU?p=preview

  • I'm submitting a ...
    [x] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository

  • Do you want to request a feature or report a bug?

I'm reporting a bug.

  • What is the current behavior?

If you load IE, and visit demo page, http://shlomiassaf.github.io/ngx-modialog/#/bootstrap-demo. This gives you flickering effect

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via
    https://plnkr.co or similar (you can use one of the templates above as a starting point).

  • What is the expected behavior?

  • What is the motivation / use case for changing the behavior?

  • Please tell us about your environment:

  • Angular version: ?
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

IE11

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

I actually managed to solve it, don't know exactly how, but here's the hack for now.

Just a hack for now, /plugins/bootstrap/bundle/ngx-modialog-bootstrap.es5.js, under create function,

change the line

        // backdrop.addClass('modal-backdrop fade', true);
        backdrop.addClass('modal-backdrop', true);

and add a line

            backdrop.addClass('fade');
            backdrop.removeClass(animationClass);

This will remove the flicking effect in IE. I can do a PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant