visit:download-db does not seem to be downloading the geo database

[ajmas]

Right now we aren't seeing the geo locations for the analytics resolved. Running the following the command line, form with the Docker images results in an error.

cmd: ./bin/cli visit:locate -n

output:

 Downloading GeoLite2 db file...
    0 [>---------------------------]

                                                                                                                        
 [OK] GeoLite2 db file properly downloaded.                                                                             
                                                                                                                        

Processing IP 107.179.249.0

                                                                                                                        
 [ERROR] The file "/etc/shlink/config/autoload/../../data/GeoLite2-City.mmdb" does not exist or is not readable.        

Trying the download command:

/etc/shlink # ./bin/cli visit:download-db
 Downloading GeoLite2 db file...
    0 [>---------------------------]

                                                                                                                        
 [OK] GeoLite2 db file properly downloaded.                                                                             

Looking in /etc/shlink/data/ only shows:

cache       locks       log         migrations  proxies

Doing a search in the docker image finds no 'GeoLite2-City.mmdb'.

Can anyone suggest what I might be doing wrong?

[acelaya]

I would suggest passing SHELL_VERBOSITY=3, to see exactly what's failing.

Also, what Shlink version are you using?

[ajmas]

I am assuming SHELL_VERBOSITY=3 is to be set as an environment variable. If it is, then I did that, via the export command, but it did not give me any more information

From what I see we are using 3.6.3, based on config/autoload/app_options.global.php

[acelaya]

Yes, that's an env var, but I thought you were seeing that error during a docker container startup (my mistake).

Instead, try running ./bin/cli visit:download-db -vvv

[ajmas]

This isn't making a difference within the docker container:

/etc/shlink # ./bin/cli visit:download-db -vvv
 Downloading GeoLite2 db file...
    0 [>---------------------------] < 1 sec 10.0 MiB

                                                                                                                        
 [OK] GeoLite2 db file properly downloaded.                                                                             

All the verbosity levels give the same result.

Right now the only workaround I have is manually downloading, using curl.

Update: digging into the code, I can't see where downloadFreshCopy is defined? In GeolocationDbUpdater.php I see the following call, but not the function it is referring to (not even in GeolocationDbUpdaterInterface.php):

$this->dbUpdater->downloadFreshCopy($this->wrapHandleProgressCallback($handleProgress, $olderDbExists));

Okay, I have not found it in vendor/shlinkio/shlink-ip-geolocation/src/GeoLite2/DbUpdater.php

So the cause of the problem appears to be this line triggering:

        if (! $this->options->hasLicenseKey()) {
            throw MissingLicenseException::forMissingLicense();
        }

We don't have the license configured, but nothing in the output indicated that we were missing the license key, so it was non-obvious that was the cause.

Suggested resolution: ensure the failure is handled and passed onto the user.

[acelaya]

If a license key is not provided, Shlink will never try to download the GeoLite2 file.

I agree that perhaps there should be a better error handling in case that command is manually run, though.

[acelaya]

Created an issue to tackle this #1877