From bc5b3af9d1954e9990d6aeb92339b76334102f7c Mon Sep 17 00:00:00 2001 From: malakaganga Date: Thu, 1 Jun 2023 11:55:36 +0530 Subject: [PATCH] Fix review comments --- .../transport/passthru/TargetHandler.java | 3 +-- .../config/PassThroughConfiguration.java | 16 ++++++++-------- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/TargetHandler.java b/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/TargetHandler.java index 7d3f9f44ac..bfc58a9e14 100644 --- a/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/TargetHandler.java +++ b/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/TargetHandler.java @@ -459,8 +459,7 @@ public void responseReceived(NHttpClientConnection conn) { return; } if (targetResponse.isForceShutdownConnectionOnComplete() && conf.isConsumeAndDiscard()) { - ClientWorker clientWorker = new ClientWorker(targetConfiguration, requestMsgContext, targetResponse, - allowedResponseProperties); + ClientWorker clientWorker = new ClientWorker(targetConfiguration, requestMsgContext, targetResponse); targetConfiguration.getSecondaryWorkerPool().execute(new MessageDiscardWorker(requestMsgContext, targetResponse, targetConfiguration, clientWorker, conn)); return; diff --git a/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/config/PassThroughConfiguration.java b/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/config/PassThroughConfiguration.java index c7d18d2562..678afb9a2c 100644 --- a/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/config/PassThroughConfiguration.java +++ b/modules/transports/core/nhttp/src/main/java/org/apache/synapse/transport/passthru/config/PassThroughConfiguration.java @@ -90,8 +90,8 @@ public int getWorkerPoolCoreSize() { DEFAULT_WORKER_POOL_SIZE_CORE); } public int getSecondaryWorkerPoolCoreSize() { - return ConfigurationBuilderUtil.getIntProperty(PassThroughConfigPNames.SECONDARY_WORKER_POOL_SIZE_CORE, - DEFAULT_WORKER_POOL_SIZE_CORE, props); + return getIntProperty(PassThroughConfigPNames.SECONDARY_WORKER_POOL_SIZE_CORE, + DEFAULT_WORKER_POOL_SIZE_CORE); } public int getWorkerPoolMaxSize() { @@ -99,8 +99,8 @@ public int getWorkerPoolMaxSize() { DEFAULT_WORKER_POOL_SIZE_MAX); } public int getSecondaryWorkerPoolMaxSize() { - return ConfigurationBuilderUtil.getIntProperty(PassThroughConfigPNames.SECONDARY_WORKER_POOL_SIZE_MAX, - DEFAULT_WORKER_POOL_SIZE_MAX, props); + return getIntProperty(PassThroughConfigPNames.SECONDARY_WORKER_POOL_SIZE_MAX, + DEFAULT_WORKER_POOL_SIZE_MAX); } public int getWorkerThreadKeepaliveSec() { @@ -109,8 +109,8 @@ public int getWorkerThreadKeepaliveSec() { } public int getSecondaryWorkerThreadKeepaliveSec() { - return ConfigurationBuilderUtil.getIntProperty(PassThroughConfigPNames.SECONDARY_WORKER_THREAD_KEEPALIVE_SEC, - DEFAULT_WORKER_THREAD_KEEPALIVE_SEC, props); + return getIntProperty(PassThroughConfigPNames.SECONDARY_WORKER_THREAD_KEEPALIVE_SEC, + DEFAULT_WORKER_THREAD_KEEPALIVE_SEC); } public int getWorkerPoolQueueLen() { @@ -119,8 +119,8 @@ public int getWorkerPoolQueueLen() { } public int getSecondaryWorkerPoolQueueLen() { - return ConfigurationBuilderUtil.getIntProperty(PassThroughConfigPNames.SECONDARY_WORKER_POOL_QUEUE_LENGTH, - DEFAULT_WORKER_POOL_QUEUE_LENGTH, props); + return getIntProperty(PassThroughConfigPNames.SECONDARY_WORKER_POOL_QUEUE_LENGTH, + DEFAULT_WORKER_POOL_QUEUE_LENGTH); } public int getIOThreadsPerReactor() {