[Perennial Self Report] Mutable states set in upgradeable contract constructor

[prateekdefi]

Issue details

Some upgradeable contracts set mutable states in constructor, which will impact their proxies as proxy storage won't have them and are set to zero on proxies which could not be updated.

Code snippet

contract Controller is Factory, IController {
    /// @inheritdoc IController
    IMarketFactory public marketFactory;

    /// @inheritdoc IController
    IAccountVerifier public verifier;

    /// @dev Creates instance of Controller
    /// @param implementation_ Collateral account contract initialized with stablecoin addresses
    constructor(address implementation_) Factory(implementation_) {
        USDC = Account(implementation_).USDC();
        DSU = Account(implementation_).DSU();
    }
}

https://github.com/sherlock-audit/2024-08-perennial-v2-update-3/blob/main/perennial-v2/packages/perennial-account/contracts/Controller.sol#L26-L65

[sherlock-admin2]

The protocol team fixed this issue in the following PRs/commits:
equilibria-xyz/perennial-v2#449