Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silver_eth - The conf of the pyth returned price are not validated #80

Open
sherlock-admin3 opened this issue Sep 13, 2024 · 0 comments

Comments

@sherlock-admin3
Copy link

sherlock-admin3 commented Sep 13, 2024

silver_eth

Medium

The conf of the pyth returned price are not validated

as explained in the following, the conf and expo values returned by the pyth oracle should be validated to ensure the protocol is not using far off prices

(https://solodit.xyz/issues/m-01-pyth-oracle-price-is-not-validated-properly-pashov-audit-group-none-nabla-markdown)
https://docs.pyth.network/price-feeds/best-practices#confidence-intervals

the pyth factory already has logic to ensure the price it returns is in 18 decimals, but it doesnt ensure conf which is necessary for the validity of the price

@sherlock-admin3 sherlock-admin3 changed the title Low Grey Mustang - The conf of the pyth returned price are not validated silver_eth - The conf of the pyth returned price are not validated Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant