Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nikhilx0111 - incase of a malicious operartor no fee will be claimed #75

Open
sherlock-admin4 opened this issue Sep 13, 2024 · 0 comments

Comments

@sherlock-admin4
Copy link
Contributor

sherlock-admin4 commented Sep 13, 2024

nikhilx0111

High

incase of a malicious operartor no fee will be claimed

Summary

the claimfee function in market.sol claims any accrued fees, fees include: protocol, oracle, risk, donation, and claimable however the function is restricted to be only called by the operator this can be problematic since it is also mentioned in the documentation that there's a possibility of a malicious operator incase of a malicious operator no protocol, oracle, risk, donation, and claimable fee will be claimed

Root Cause

https://github.com/sherlock-audit/2024-08-perennial-v2-update-3/blob/main/perennial-v2/packages/perennial/contracts/Market.sol#L292

Internal pre-conditions

No response

External pre-conditions

No response

Attack Path

No response

Impact

protocol wont be able to collect any fee

PoC

No response

Mitigation

allow both the owner and operator to collect accrued fees

@sherlock-admin3 sherlock-admin3 changed the title Brave Crimson Yak - incase of a malicious operartor no fee will be claimed nikhilx0111 - incase of a malicious operartor no fee will be claimed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant