Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming conventions #1

Open
sheriffderek opened this issue Oct 10, 2016 · 1 comment
Open

Consistent naming conventions #1

sheriffderek opened this issue Oct 10, 2016 · 1 comment

Comments

@sheriffderek
Copy link
Owner

Consistent naming conventions:

So far, variables are named like this:

$gray          = lighten($black, 50%)
$gray-light    = lighten($gray, 50%)
$gray-dark     = darken($gray, 50%)
$gray-lighter  = lighten($gray-light, 50%)

The color is gray 1st - and 'light' 2nd.

"Themes" are named like this so far:

light-theme() or dark-theme()

Should they be theme-light() ?

This isn't the biggest deal ever... but these things should be intuitive so I don't have to ever go check for, "Well, is it light-gray or gray-light?

@sheriffderek
Copy link
Owner Author

Another place where this exists is extra-small-type(). I definitely do not want to write type-small-extra() ... so maybe that's one vote for descriptor first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant