Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location parameter is ignored from v0.17.0 #158

Open
somq opened this issue Feb 28, 2022 · 1 comment · May be fixed by #184
Open

location parameter is ignored from v0.17.0 #158

somq opened this issue Feb 28, 2022 · 1 comment · May be fixed by #184

Comments

@somq
Copy link

somq commented Feb 28, 2022

Describe the bug
From version 0.17.0, the location configuration parameter seems ignored.
Therefore the target lambdas are from the last package in .serverless folder and lambdas won't get refreshed on hot-reload.

To Reproduce
Set a location configuration parameter to any custom lambdas build path.
Example with serverless-webpack

custom:
  appsync-simulator:
    location: '.webpack/service' # use webpack build directory

Expected behavior
Custom lambdas location path should be resolved.

Additional context

I've been digging the issue a bit and it has probably been introduced by this commit between 0.16.1 and 0.17.0.
For some reasons, the context.options.location does not appear anymore in the lambda invokation request.

Maybe there is something I don't know behind the scenes because I tend to remember that there were changes in serverless & serverless offline regarding lambda invokations in plugins.
In any case, the issue has been introduced at version 0.17.0 anyway.

@bot403
Copy link

bot403 commented Jan 17, 2023

Bump. Our company is being hit by this and this is making us hold back the version of serverless-appsync-simulator to 0.16.1 as a workaround - but that will be more painful as time goes on.

@un-focused un-focused linked a pull request Mar 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants