Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profession Droptimizer should carry over additional sockets/embellishments for recrafts #397

Open
cremor opened this issue Feb 24, 2023 · 0 comments

Comments

@cremor
Copy link

cremor commented Feb 24, 2023

Is your feature request related to a problem? Please describe.
I'm having a hard time comparing upgrades when I run Droptimizer for professions because items that are direct item level upgrades of equipped items (meaning I can recraft them) don't inherit the additional sockets/embellishments of the equipped items.

Describe the solution you'd like
If a profession Droptimizer result is a higher item level of an item that is already equipped it should also have all sockets and embellishments from the equipped item.
Additionally it should show an info that this is a recraft.

Describe alternatives you've considered
It could also add both item variants to the results - so the one like it is today and the recraft.

Additional context
Example report: https://www.raidbots.com/simbot/report/ucZ9MGVQK7EwP6N4DR6WZr
The Unstable Frostfire Belt should be valued higher because a recraft of it will still have the socket.
And the Primal Molten Greataxe should not be shown as a downgrade because I have the item equipped (with an embellishment). Although that would then lead to a weird situation were the other weapons would still be downgrades. So maybe the solution should even carry over embellishments (but not sockets) to items of the same slot?

An even better solution would also consider items in the bag for possible recrafts. But that would get more complicated to correctly compare because of possible violations of the limit of 2 embellishments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant