Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nice to have] Include a test suite that includes a mock Amazon object with all potential values #15

Open
YPCrumble opened this issue Mar 12, 2020 · 2 comments
Labels
feature New feature or request

Comments

@YPCrumble
Copy link
Contributor

It would be really nice to have a test suite for the repo. In particular, including something like mocks.py that includes a mock product returned by this repo would help users to unit test our applications.

I may have time to start on this - I focus only on books but could be a good start to creating a test suite for this repo.

Would also be nice to show code coverage and test suite status on CI.

@YPCrumble
Copy link
Contributor Author

YPCrumble commented Mar 12, 2020

A mock of the Amazon SDK's return value would also work. You would be able to use that mock for unit testing this application, and as a developer I could simply parse that mock to unit test my application. Basically a mock product object that includes a mock value for every single potential attribute.

Thanks again for making this repo!

@sergioteula sergioteula added the feature New feature or request label Mar 13, 2020
@sergioteula
Copy link
Owner

That's a very good idea, it would also help me testing the wrapper at development. I want to work first on refining the product instance structure, and then we can work on the test suite. Keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants