Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: drop Node 16 support in v7 #577

Merged
merged 4 commits into from
Sep 13, 2023
Merged

docs: drop Node 16 support in v7 #577

merged 4 commits into from
Sep 13, 2023

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Sep 12, 2023

ephys
ephys previously approved these changes Sep 12, 2023
@WikiRik WikiRik marked this pull request as draft September 12, 2023 08:37
@WikiRik
Copy link
Member Author

WikiRik commented Sep 12, 2023

Putting this to draft to see if I might expand the scope of this. I want to try updating eslint-plugin-jsdoc in v6 to a version that supports Node 18

@WikiRik
Copy link
Member Author

WikiRik commented Sep 12, 2023

The PR that added support for Node 18 (which apparently was mine), was added after Node 10 support was dropped so we'll remain using Node 16 for now and add a patch/fix for this later

@WikiRik WikiRik marked this pull request as ready for review September 12, 2023 11:53
@WikiRik WikiRik requested a review from ephys September 12, 2023 11:53
@github-actions
Copy link

@WikiRik
Copy link
Member Author

WikiRik commented Sep 12, 2023

Will merge this after sequelize/sequelize#16487 has been merged

@WikiRik WikiRik merged commit 5691507 into main Sep 13, 2023
1 check passed
@WikiRik WikiRik deleted the WikiRik/drop-Node-16 branch September 13, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants