Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7-alpha connectionManager.initPools missing #726

Open
3 of 6 tasks
ghost opened this issue Sep 26, 2023 · 1 comment
Open
3 of 6 tasks

V7-alpha connectionManager.initPools missing #726

ghost opened this issue Sep 26, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 26, 2023

Issue Creation Checklist

  • I understand that my issue will be automatically closed if I don't fill in the requested information
  • I have read the contribution guidelines

Bug Description

Using V7-alpha the connectionManager no longer has a initPools method to restart the connection pool when using it in an AWS Lambda environment.

Is the way to do this changed in V7? I tried looking through the source but could not find a way to do this with the same behaviour as on V6

Reproducible Example

Here is the link to the SSCCE for this issue:

What do you expect to happen?

What is actually happening?

Environment

  • Sequelize version: 7.0.0-alpha.32
  • Node.js version: v18.16.0
  • If TypeScript related: TypeScript version:
  • Database & Version: PostgreSQL
  • Connector library & Version:

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in resolving my issue.

Indicate your interest in the resolution of this issue by adding the 👍 reaction. Comments such as "+1" will be removed.

@WikiRik
Copy link
Member

WikiRik commented Sep 26, 2023

That code has moved to the constructor in sequelize/sequelize#14652. As maintainers we don't have AWS Lambda experience as far as I know so this one is up to the community. Once this is cleared up, feel free to open a PR to update the page

@ephys ephys transferred this issue from sequelize/sequelize Mar 27, 2024
@ephys ephys removed the type: docs label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants